Skip to content

Conversation

MSeal
Copy link
Contributor

@MSeal MSeal commented Oct 6, 2025

Moves the async classes into an experimental module to avoid accidental use. We can revert this PR once we're moving to mainstream support.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 21:49
@MSeal MSeal requested review from a team as code owners October 6, 2025 21:49
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the async (AIOProducer/AIOConsumer) classes from the main confluent_kafka.aio package into the experimental module at confluent_kafka.experimental.aio to avoid accidental use in production environments. This change allows for a regular release while marking the async functionality as experimental until it reaches mainstream support.

Key changes:

  • Relocated all async classes from confluent_kafka.aio to confluent_kafka.experimental.aio
  • Updated all import statements across tests, examples, and documentation
  • Created new experimental module structure with proper __init__.py files

Reviewed Changes

Copilot reviewed 22 out of 25 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/confluent_kafka/experimental/ New experimental module structure with async classes
tests/ Updated import paths to use experimental namespace
examples/ Updated import paths and documentation to reflect experimental status
README.md Updated documentation to mark AsyncIO as experimental
DEVELOPER.md Updated project layout documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 78 to 79


Copy link
Preview

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Unnecessary trailing blank lines at the end of the file. Consider removing the extra blank line.

Suggested change

Copilot uses AI. Check for mistakes.

Comment on lines 19 to 20


Copy link
Preview

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Unnecessary trailing blank lines at the end of the file. Consider removing the extra blank line.

Suggested change

Copilot uses AI. Check for mistakes.

Comment on lines 156 to 157


Copy link
Preview

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Unnecessary trailing blank lines at the end of the file. Consider removing the extra blank line.

Suggested change

Copilot uses AI. Check for mistakes.

Comment on lines 21 to 22


Copy link
Preview

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Unnecessary trailing blank line at the end of the file. Consider removing it.

Suggested change

Copilot uses AI. Check for mistakes.

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@k-raina k-raina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! LGTM
One of semaphore block is failing in pipeline, can we fix that?

@pranavrth
Copy link
Member

pranavrth commented Oct 7, 2025

@k-raina - I am fixing the style issues.

@sonarqube-confluent

This comment has been minimized.

4 similar comments
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (66.90% Estimated after merge)
  • Duplications No duplication information (4.90% Estimated after merge)

Project ID: confluent-kafka-python

View in SonarQube

@MSeal MSeal enabled auto-merge (squash) October 8, 2025 02:47
@MSeal MSeal merged commit f443ea6 into master Oct 8, 2025
3 checks passed
@MSeal MSeal deleted the async-experimental branch October 8, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants