-
Notifications
You must be signed in to change notification settings - Fork 934
Moved async into experimental package for regular release #2089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves the async (AIOProducer/AIOConsumer) classes from the main confluent_kafka.aio
package into the experimental module at confluent_kafka.experimental.aio
to avoid accidental use in production environments. This change allows for a regular release while marking the async functionality as experimental until it reaches mainstream support.
Key changes:
- Relocated all async classes from
confluent_kafka.aio
toconfluent_kafka.experimental.aio
- Updated all import statements across tests, examples, and documentation
- Created new experimental module structure with proper
__init__.py
files
Reviewed Changes
Copilot reviewed 22 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/confluent_kafka/experimental/ | New experimental module structure with async classes |
tests/ | Updated import paths to use experimental namespace |
examples/ | Updated import paths and documentation to reflect experimental status |
README.md | Updated documentation to mark AsyncIO as experimental |
DEVELOPER.md | Updated project layout documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Unnecessary trailing blank lines at the end of the file. Consider removing the extra blank line.
Copilot uses AI. Check for mistakes.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Unnecessary trailing blank lines at the end of the file. Consider removing the extra blank line.
Copilot uses AI. Check for mistakes.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Unnecessary trailing blank lines at the end of the file. Consider removing the extra blank line.
Copilot uses AI. Check for mistakes.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Unnecessary trailing blank line at the end of the file. Consider removing it.
Copilot uses AI. Check for mistakes.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR! LGTM
One of semaphore block is failing in pipeline, can we fix that?
@k-raina - I am fixing the style issues. |
Moves the async classes into an experimental module to avoid accidental use. We can revert this PR once we're moving to mainstream support.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups