Skip to content

Conversation

k-raina
Copy link
Member

@k-raina k-raina commented Oct 7, 2025

Summary

  • Update performance bounds for local and CI environment
  • Enhanced Async Producer Strategy (tests/ducktape/producer_strategy.py), added polling logic to async producer to match sync producer behavior

JIRA : https://confluentinc.atlassian.net/browse/NONJAVACLI-3971

@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 14:48
@k-raina k-raina requested review from a team and MSeal as code owners October 7, 2025 14:48
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@k-raina k-raina changed the title Set performance bounds Set performance bounds for CI and local Oct 7, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates performance bounds for both local and CI environments and enhances the Async Producer Strategy with polling logic to match sync producer behavior.

  • Updated performance bounds with more relaxed latency thresholds for both local and CI environments
  • Added polling logic to the async producer strategy with configurable interval and metrics tracking

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/ducktape/producer_strategy.py Added periodic polling logic to async producer with metrics tracking
tests/ducktape/producer_benchmark_bounds.json Increased p95 and p99 latency thresholds for local and CI environments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqube-confluent

This comment has been minimized.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change the tests to go back to failing test execution on bounds failure to block PRs?

@k-raina
Copy link
Member Author

k-raina commented Oct 7, 2025

@MSeal Thanks! FIxed

@k-raina k-raina requested a review from MSeal October 7, 2025 18:50
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent
Copy link

Passed

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage No coverage information (66.90% Estimated after merge)
  • Duplications No duplication information (4.90% Estimated after merge)

Project ID: confluent-kafka-python

View in SonarQube

"max_memory_growth_mb": 800.0,
"max_buffer_full_rate": 0.05,
"min_messages_per_poll": 10.0
"min_messages_per_poll": 5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should just remove min_messages_per_poll, as messages_per_poll is essentially equal to the batch_size according to our code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants