-
Notifications
You must be signed in to change notification settings - Fork 935
Set performance bounds for CI and local #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates performance bounds for both local and CI environments and enhances the Async Producer Strategy with polling logic to match sync producer behavior.
- Updated performance bounds with more relaxed latency thresholds for both local and CI environments
- Added polling logic to the async producer strategy with configurable interval and metrics tracking
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/ducktape/producer_strategy.py | Added periodic polling logic to async producer with metrics tracking |
tests/ducktape/producer_benchmark_bounds.json | Increased p95 and p99 latency thresholds for local and CI environments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also change the tests to go back to failing test execution on bounds failure to block PRs?
@MSeal Thanks! FIxed |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
"max_memory_growth_mb": 800.0, | ||
"max_buffer_full_rate": 0.05, | ||
"min_messages_per_poll": 10.0 | ||
"min_messages_per_poll": 5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should just remove min_messages_per_poll, as messages_per_poll is essentially equal to the batch_size according to our code
Summary
JIRA : https://confluentinc.atlassian.net/browse/NONJAVACLI-3971