Skip to content

fix(idempotency): make kafka-storage commands return correct changed_when status #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: 7.9.x
Choose a base branch
from
Open

fix(idempotency): make kafka-storage commands return correct changed_when status #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f3e917
fix(idempotency): add changed_when: false to shell commands that do n…
sverrehu Feb 10, 2025
2644114
fix(idempotency): only report change when log dir is formatted
sverrehu Feb 10, 2025
1388834
Merge branch 'confluentinc:7.9.x' into 7.9.x
sverrehu Feb 16, 2025
250ca8b
Merge branch 'confluentinc:7.9.x' into 7.9.x
sverrehu Feb 18, 2025
738c598
Merge branch 'confluentinc:7.9.x' into 7.9.x
sverrehu May 20, 2025
880aef6
Merge branch 'confluentinc:7.9.x' into 7.9.x
sverrehu Jun 17, 2025
e5ff016
Merge branch 'confluentinc:7.9.x' into 7.9.x
sverrehu Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion roles/kafka_broker/tasks/get_meta_properties.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
register: uuid_broker

- name: Format Storage Directory
shell: "{{ binary_base_path }}/bin/kafka-storage format -t={{ clusterid }} -c {{ kafka_broker.config_file }} --ignore-formatted"
shell: "{{ binary_base_path }}/bin/kafka-storage format -t={{ clusterid }} -c {{ kafka_broker.config_file }} --ignore-formatted"
register: format_meta
changed_when: format_meta.stdout_lines is not search('already formatted', multiline=true)
vars:
clusterid: "{{ (uuid_broker['content'] | b64decode).partition('cluster.id=')[2].partition('\n')[0] }}"
2 changes: 2 additions & 0 deletions roles/kafka_controller/tasks/get_meta_properties.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@
shell: "{{ binary_base_path }}/bin/kafka-storage info -c {{ kafka_controller.config_file }}"
ignore_errors: true
failed_when: false
changed_when: false
register: formatted

- name: Get ClusterId
shell: "{{ binary_base_path }}/bin/kafka-storage random-uuid"
environment:
KAFKA_OPTS: "-Xlog:all=error -XX:+IgnoreUnrecognizedVMOptions"
changed_when: false
register: uuid_key
run_once: true
when: not kraft_migration|bool
Expand Down