Skip to content

Conversation

@yalindogusahin
Copy link

@yalindogusahin yalindogusahin commented Feb 13, 2025

Description

Kraft controller raft-metrics won't be exposed via JMX exporter by default. Since they are valuable metrics we should add it to the related ansible template.

Fixes # (1899)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I've tested on my local environment. Raft metrics has been exposed without issues.

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@yalindogusahin yalindogusahin requested a review from a team as a code owner February 13, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant