-
Notifications
You must be signed in to change notification settings - Fork 419
[8.1.x][ANSIENG-4730] | Implement logrotate for prometheus & alertmanager
#2306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Demo & Troubleshooting To force log rotation use following command |
rkunwar-28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine. How have we tested this? Ideally, we should spin up a setup with a very small value for file size limit and make sure that new log files are getting created everytime that file size is breached.
|
Yes testing details here #2306 (comment) |
rkunwar-28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed the demo screenshot above, this is fine. Prometheus log file size is set to 1K and it is getting rotated properly
rkunwar-28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Good idea to incorporate the validations, we can add similar validations for USM Agent as well.
…eus` & `alertmanager` (#2306)
…eus` & `alertmanager` (#2306)
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: