-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Attempt manual merge from KSQL 6.2.X to 7.0.X #10019
Open
bideyio
wants to merge
12
commits into
master
Choose a base branch
from
bdey-ksql-merge-6-7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The guava version used in ksql is affected by CVE-2023-2976. This PR upgrades the guava dependency to 32.0.1. https://confluentinc.atlassian.net/browse/KSE-1714
Merge Conflict Resolution (from 6.0.x to 6.1.x)
Merge Conflict Resolution (from 6.1.x to 6.2.x)
Merge Conflict Resolution (from 6.1.x to 6.2.x)
bideyio
changed the title
Attempt manual merge from KSQL 6.2.X to 7.0.X
[DO NOT MERGE] Attempt manual merge from KSQL 6.2.X to 7.0.X
Jul 17, 2023
AlanConfluent
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to fix merge conflicts manually due to automatic merge failure - https://jenkins.confluent.io/job/tools-autotasks/job/tools-autotasks/job/apply-pint-merge/2776/console
More context is available in this thread - https://confluent.slack.com/archives/C9Z794XSL/p1689626881653259
To follow the merge procedure use this guide - https://confluentinc.atlassian.net/wiki/spaces/DOC/pages/585564416/Fixing+pint+merge+conflicts
How to reproduce this branch and resolve conflicts. Make sure you are on the master branch.
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist