Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes#KSE-1846: Fix for select struct->* for Pull Queries #10413

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fixes#KSE-1846: Fix for select struct->* for Pull Queries #10413

merged 1 commit into from
Sep 25, 2024

Conversation

hrishabhg
Copy link
Member

@hrishabhg hrishabhg commented Aug 26, 2024 •
edited
Loading

Description

Expansion of stuctField->* fails for pull-queries though works for streaming/push queries. This change is to fix the expansion. (Fixes #KSE-1846)

Testing done

Yes (Unit Tests & Functional Tests)

Reviewer checklist

  • (Not Applicable) Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@hrishabhg hrishabhg requested a review from a team as a code owner August 26, 2024 05:57
pbadani
pbadani previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@pbadani pbadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hrishabhg, LGTM.

@hrishabhg hrishabhg removed the request for review from VedarthConfluent August 27, 2024 04:09
@hrishabhg hrishabhg changed the base branch from 7.3.x to master August 27, 2024 04:11
@hrishabhg hrishabhg dismissed pbadani’s stale review August 27, 2024 04:11

The base branch was changed.

@hrishabhg hrishabhg changed the base branch from master to 7.3.x August 27, 2024 04:12
@hrishabhg hrishabhg enabled auto-merge (squash) August 27, 2024 04:18
@hrishabhg hrishabhg requested a review from pbadani August 27, 2024 04:19
@hrishabhg hrishabhg merged commit 107064a into 7.3.x Sep 25, 2024
2 checks passed
@hrishabhg hrishabhg deleted the select_struct_star_fix_7.3 branch September 25, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbadani pbadani pbadani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrishabhg @pbadani