Add support for external modules #548
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Pavlovic <[email protected]>
Modules can now be run remotely, outside the Mir node, in a dedicated module server. The Mir node can use a proxy module that connects to this server over a websocket interface and relays all the incoming events to the remote server. The server applies the events to its local module (which implements the actual module logic) and sends back the results. Those resulting events are then emitted by the proxy module (which lives in the Mir node). Signed-off-by: Matej Pavlovic <[email protected]>
Except for integer conversions that used not to be an issue but popped up with new linter version. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
externalmodule
branch
from
9c4f617 to
b66ac95
Compare
This mostly relates to integer conversions. In the most cases, the conversions are safe and thus disabled. Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
externalmodule
branch
from
b66ac95 to
cbf51b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules can now be run remotely, outside the Mir node,
in a dedicated module server.
The Mir node can use a proxy module that connects to this server
over a websocket interface and relays all the incoming events
to the remote server. The server applies the events to its local module
(which implements the actual module logic) and sends back the results.
Those resulting events are then emitted by the proxy module
(which lives in the Mir node).