Skip to content

2.x php8 compat#250

Merged
aik099 merged 7 commits intoconsole-helpers:masterfrom
dnadesign:2.x-php8-compat
Mar 5, 2026
Merged

2.x php8 compat#250
aik099 merged 7 commits intoconsole-helpers:masterfrom
dnadesign:2.x-php8-compat

Conversation

@alex-dna
Copy link
Contributor

@alex-dna alex-dna commented Mar 1, 2026

Hi.
We found that using the module with PHP 8 triggered a few deprecation warnings, so this MR aims at correcting them.
This is also bumping the minimum PHP version to 7.1. Not sure if that something you would want to do.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.54%. Comparing base (70d9b95) to head (a3609c0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
+ Coverage     83.51%   84.54%   +1.03%     
  Complexity      208      208              
============================================
  Files            10       10              
  Lines           558      550       -8     
============================================
- Hits            466      465       -1     
+ Misses           92       85       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your proposal. Let's do a few more changes to prepare PR for merging.

Please also add a line in the CHANGELOG.md file (1st line with a change + 2nd line at the file bottom for PR author link to work if you're a 1st time contributor in this repository).

@alex-dna alex-dna requested a review from aik099 March 2, 2026 22:09
Copy link
Member

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

Copy link
Member

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Everything else looks solid.

@aik099 aik099 merged commit f618d6c into console-helpers:master Mar 5, 2026
7 checks passed
@aik099
Copy link
Member

aik099 commented Mar 5, 2026

Merging. Thank you @alex-dna.

If you have time to spend on this project, that I'll be happy to review your PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants