Skip to content

Added --export command #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

craigloewen-msft
Copy link

I made a PR to add the --export command to nerdctl.

I did it to solve issues like #1854 and since I saw it had support from the maintainers.

I also looked at this PR for inspiration: https://github.com/containerd/nerdctl/pull/2161/files

Please let me know if you want any changes or if it looks good!

craigloewen-msft and others added 2 commits July 9, 2025 10:55
@craigloewen-msft
Copy link
Author

@AkihiroSuda is this change good to go? Anything else I can do to help merge this in? :)

@AkihiroSuda
Copy link
Member

Not compilable 😞

https://github.com/containerd/nerdctl/actions/runs/16174086400/job/45654760202?pr=4405

# github.com/containerd/nerdctl/v2/pkg/cmd/container
Error: pkg/cmd/container/export.go:69:38: undefined: containerutil.MountSnapshotForContainer

@craigloewen-msft
Copy link
Author

Not compilable 😞

https://github.com/containerd/nerdctl/actions/runs/16174086400/job/45654760202?pr=4405

# github.com/containerd/nerdctl/v2/pkg/cmd/container
Error: pkg/cmd/container/export.go:69:38: undefined: containerutil.MountSnapshotForContainer

Fixed the build!

@craigloewen-msft
Copy link
Author

@AkihiroSuda I fixed the PR!
Looks like all the linting succeeds now, it's using the correct WriteDiff function and the only failing tests seem to be from other causes.

@apostasie
Copy link
Contributor

@craigloewen-msft
Copy link
Author

@apostasie thank you for the spot. Seems like somehow it's failing on Windows? Would need to dig into that further but for now I have to pause for a little to prioritize my other work.

@craigloewen-msft
Copy link
Author

Errors seem to be an access denied error and a can't access the file since it's already in use. Maybe my use of the snapshotter here is bad??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants