-
Notifications
You must be signed in to change notification settings - Fork 678
Added --export command #4405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added --export command #4405
Conversation
Co-authored-by: Akihiro Suda <[email protected]> Signed-off-by: Craig Loewen <[email protected]>
@AkihiroSuda is this change good to go? Anything else I can do to help merge this in? :) |
Not compilable 😞 https://github.com/containerd/nerdctl/actions/runs/16174086400/job/45654760202?pr=4405
|
Fixed the build! |
@AkihiroSuda I fixed the PR! |
@craigloewen-msft |
@apostasie thank you for the spot. Seems like somehow it's failing on Windows? Would need to dig into that further but for now I have to pause for a little to prioritize my other work. |
Errors seem to be an access denied error and a can't access the file since it's already in use. Maybe my use of the snapshotter here is bad?? |
I made a PR to add the
--export
command to nerdctl.I did it to solve issues like #1854 and since I saw it had support from the maintainers.
I also looked at this PR for inspiration: https://github.com/containerd/nerdctl/pull/2161/files
Please let me know if you want any changes or if it looks good!