Enable linters for enforce-switch-style & redundant-test-main-exit
#4496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
AkihiroSuda
reviewed
Sep 1, 2025
| @@ -55,15 +47,11 @@ func TestMain(m *testing.M) { | |||
| for _, file := range diff { | |||
| fmt.Fprintln(os.Stderr, file) | |||
| } | |||
|
|
|||
| exitCode = 1 | |||
There was a problem hiding this comment.
This is irrelevant to redundant-test-main-exit
AkihiroSuda
reviewed
Sep 1, 2025
| } | ||
| } | ||
|
|
||
| if err := highk.FindGoRoutines(); err != nil { | ||
| fmt.Fprintln(os.Stderr, "Leaking go routines") | ||
| fmt.Fprintln(os.Stderr, os.Stderr, err.Error()) | ||
|
|
||
| exitCode = 1 |
There was a problem hiding this comment.
This is irrelevant to redundant-test-main-exit
AkihiroSuda
reviewed
Sep 1, 2025
| @@ -55,15 +47,11 @@ func TestMain(m *testing.M) { | |||
| for _, file := range diff { | |||
| fmt.Fprintln(os.Stderr, file) | |||
| } | |||
|
|
|||
| exitCode = 1 | |||
There was a problem hiding this comment.
This is irrelevant to redundant-test-main-exit
AkihiroSuda
reviewed
Sep 1, 2025
| } | ||
| } | ||
|
|
||
| if err := highk.FindGoRoutines(); err != nil { | ||
| fmt.Fprintln(os.Stderr, "Leaking go routines") | ||
| fmt.Fprintln(os.Stderr, err.Error()) | ||
|
|
||
| exitCode = 1 |
There was a problem hiding this comment.
This is irrelevant to redundant-test-main-exit
AkihiroSuda
reviewed
Sep 1, 2025
| @@ -96,7 +96,6 @@ linters: | |||
| - "fmt.Fprintln" | |||
| - "fmt.Fprintf" | |||
| - name: redundant-test-main-exit | |||
AkihiroSuda
reviewed
Sep 1, 2025
| @@ -185,9 +185,6 @@ linters: | |||
| # 2605 occurrences. Kind of useful in itself, but unacceptable amount of effort to fix | |||
| disabled: true | |||
| - name: enforce-switch-style | |||
AkihiroSuda
reviewed
Sep 1, 2025
| @@ -28,6 +28,7 @@ func TestComposePauseAndUnpause(t *testing.T) { | |||
| switch base.Info().CgroupDriver { | |||
| case "none", "": | |||
| t.Skip("requires cgroup (for pausing)") | |||
| default: | |||
There was a problem hiding this comment.
nit: add // NOP to clarify that this empty default is not a typo
default:
// NOPSame for other occurrences too
AkihiroSuda
reviewed
Sep 1, 2025
| @@ -97,7 +97,6 @@ linters: | |||
| - "fmt.Fprintf" | |||
| - name: redundant-test-main-exit | |||
| - name: enforce-switch-style | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4493, in parts.
redundant-test-main-exit&enforce-switch-stylein golangci file.defaultcase otherwise.