Use async rust extensions #886
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
github-actions
bot
added
C-wasmtime
C-containerd-shim-wasm
C-wamr
C-wasmedge
C-wasmer
labels
There was a problem hiding this comment.
PR Overview
This pull request refactors a large portion of the codebase to use asynchronous Rust extensions. Key changes include converting many functions (in instances, tasks, and tests) to asynchronous equivalents, updating dependency declarations to include Tokio from the workspace, and modifying event‐sending traits to return and work with futures.
Reviewed Changes
| File | Description |
|---|---|
| crates/containerd-shim-wasm/src/sandbox/cli.rs | Converted several Shim methods (e.g. new, start_shim, wait) to async functions with updated await semantics. |
| crates/containerd-shim-wasm/src/sandbox/shim/events.rs | Changed the EventSender trait from a synchronous send method to an async function returning a future. |
| crates/containerd-shim-wasm/src/sandbox/shim/local/tests.rs | Updated tests to use Tokio’s async channels and task spawning ensuring proper awaits throughout the test lifecycle. |
| crates/containerd-shim-wasm/src/sandbox/instance_data.rs | Replaced std::sync::RwLock with tokio::sync::RwLock and adjusted all lock acquisitions to be awaited. |
| Various Cargo.toml files (wasmedge, wamr) | Added Tokio as a dependency from the workspace to ensure consistent async runtime support. |
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.