Skip to content

Conversation

ningmingxiao
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the T-CI Changes in project's CI label Oct 24, 2024
@ningmingxiao ningmingxiao force-pushed the add_cri_ci branch 7 times, most recently from 50e889a to bf0686b Compare October 25, 2024 02:54
@jsturtevant
Copy link
Contributor

@ningmingxiao We already have an integration step in the workflow that does the setup and runs the tests. What is the purpose of adding this additional step?

@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Oct 31, 2024

because containerd have make integration and make cri-integration
https://github.com/containerd/containerd/blob/main/BUILDING.md
make integration is not enough. @jsturtevant
TestContainerStats TestContainerListStats TestContainerListStatsWithIdFilter TestContainerListStatsWithSandboxIdFilter TestContainerListStatsWithIdSandboxIdFilter will fail.

Signed-off-by: ningmingxiao <[email protected]>
Copy link

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the Stale label Feb 11, 2025
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale T-CI Changes in project's CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants