Repository navigation
add shared MCP Apps viewers for core Kubernetes tools - #1480
Open
nader-ziada wants to merge 2 commits into
Open
nader-ziada wants to merge 2 commits into
nader-ziada wants to merge 2 commits into
Conversation
Introduce reusable table, metrics, and resource viewers with shared embedded HTML, JavaScript, and styling. Attach viewers to namespace, project, pod, resource, event, and metrics tools. Preserve existing text output and resource payloads while adding structured data where needed. Signed-off-by: Nader Ziada <nziada@redhat.com>
Merged
Cali0707
reviewed
Oct 8, 2026
| const a = quantity(left[sortColumn]), b = quantity(right[sortColumn]); | ||
| if (Number.isFinite(a) && Number.isFinite(b)) return a - b; | ||
| } | ||
| return text(left[sortColumn]).localeCompare(text(right[sortColumn])); |
Collaborator
There was a problem hiding this comment.
from my limited JS knowledge, I believe this is actually going to compare alphabetically (not chronologically)?
Wouldn't we want to compare Age chronologically?
Collaborator
Author
There was a problem hiding this comment.
good point, i'll change it to be by age similar to the standard kubectl’s chronological ordering
Comment on lines
+35
to
+37
| if phase, found, _ := unstructured.NestedString(item.Object, "status", "phase"); found { | ||
| row["Status"] = phase | ||
| } |
Collaborator
There was a problem hiding this comment.
wouldn't this miss important info on types like Deployment/Ingress?
Collaborator
Author
There was a problem hiding this comment.
this helper only handles Pods, Namespaces, and Projects. resources_list preserves the API server’s resource-specific columns. I’ve also added Deployment readiness/replica counts and Ingress routing fields to the YAML-mode viewer, with browser tests.
Signed-off-by: Nader Ziada <nziada@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
embedded HTML, JavaScript, and styling.
tools. Preserve existing text output and resource payloads while adding
structured data where needed.
resource details, host themes, cancellation, ping, and resize reporting.
dependencies with a lockfile to eliminate npm audit findings.