attach DVD Drive on new VM - #235
Merged
Merged
Conversation
this patch allows to attach a DVD device when creating a VM. This is helpful when wanting to customize VM using cloud-init. By attaching the cloud-init config ISO as a DVD, we can deliver the configuration to the VM Signed-off-by: lstocchi <lstocchi@redhat.com>
baude
reviewed
Jun 23, 2025
| Finish(). // drive | ||
| //AddSyntheticDvdDrive(1). | ||
| //DefineVirtualDvdDisk(isoFile). | ||
| //Finish(). // disk |
Member
There was a problem hiding this comment.
are you confident this will not break other consumers of libhvee?
Contributor
Author
There was a problem hiding this comment.
quite sure. It should work as before if there is no dvd device. I tested it with podman. Not sure if there is something else to check
|
/lgtm |
|
The testing farm error does not seem to be related to this PR, some issues with golangci-lint which seem to be preexisting. |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, lstocchi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Jun 23, 2025
39252f3
into
containers:main
4 of 5 checks passed
lstocchi
added a commit
to lstocchi/podman
that referenced
this pull request
Jun 24, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
added a commit
to lstocchi/podman
that referenced
this pull request
Jun 25, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
added a commit
to lstocchi/podman
that referenced
this pull request
Jun 30, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
added a commit
to lstocchi/podman
that referenced
this pull request
Jun 30, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
added a commit
to lstocchi/podman
that referenced
this pull request
Jun 30, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
added a commit
to lstocchi/podman
that referenced
this pull request
Jun 30, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
added a commit
to lstocchi/podman
that referenced
this pull request
Jul 3, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
added a commit
to lstocchi/podman
that referenced
this pull request
Jul 3, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
added a commit
to lstocchi/podman
that referenced
this pull request
Jul 3, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
cfergeau
pushed a commit
to cfergeau/podman
that referenced
this pull request
Aug 19, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
cfergeau
pushed a commit
to cfergeau/podman
that referenced
this pull request
Aug 19, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
cfergeau
pushed a commit
to cfergeau/podman
that referenced
this pull request
Aug 26, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
cfergeau
pushed a commit
to cfergeau/podman
that referenced
this pull request
Aug 26, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
cfergeau
pushed a commit
to cfergeau/podman
that referenced
this pull request
Aug 26, 2025
it upgrades the libhvee library version. To use cloud-init on Hyperv we need to attach a DVD drive to the VM so we needs a version of libhvee that includes containers/libhvee#235 Signed-off-by: lstocchi <lstocchi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch allows to attach a DVD device when creating a VM.
This is helpful when wanting to customize VM using cloud-init. By attaching the cloud-init config ISO as a DVD, we can deliver the configuration to the VM