Return non-zero exit_code on failure when doing `up -d` #1181

zeyugao · 2025-04-08T13:08:32Z

When run podman-compose up -d, it returns directly without handling the error.

Related issues:

pids_limit spec:

https://github.com/compose-spec/compose-spec/blob/main/05-services.md#pids_limit and https://github.com/compose-spec/compose-spec/blob/main/deploy.md#pids

zeyugao · 2025-04-08T13:58:03Z

The unitest failed, but the up -d returns stderr: Error: keep-id is only supported in rootless mode. So it seems that the original unittest failed unexpectedly

Related pr: #964

podman_compose.py

p12tic · 2025-04-08T16:46:57Z

podman_compose.py

    if not args.no_build:
        # `podman build` does not cache, so don't always build
        build_args = argparse.Namespace(if_not_exists=(not args.build), **args.__dict__)
-        if await compose.commands["build"](compose, build_args) != 0:
+        build_result = await compose.commands["build"](compose, build_args)


Let's name build_exit_code

podman_compose.py

p12tic

Looks good overall.

Please add release notes to the newsfragments directory (you can look here for inspiration on how release note looks like).

p12tic · 2025-04-08T16:49:53Z

I think it's worth moving pids_limit change to separate PR, because it will take some time to understand why tests fail for your up -d changes. Also they will need an integration test, so splitting PRs will not delay the pids_limit part.

zeyugao · 2025-04-09T00:45:23Z

#1182

p12tic · 2025-04-14T15:07:50Z

Tests are currently failing, do they fail for you locally?

zeyugao · 2025-04-14T15:14:35Z

I think that the failure reason is mentioned before. Locally I use rootless podman, but in the github action, podman is run as root. In this unit test expects using keep-id which is only supported in rootless mode as shown in the stderr

podman-compose/tests/integration/in_pod/custom_x-podman_false/docker-compose.yml

Line 5 in 342a39d

userns_mode: keep-id:uid=1000

p12tic · 2025-04-21T20:57:40Z

I think that the failure reason is mentioned before. Locally I use rootless podman, but in the github action, podman is run as root. In this unit test expects using keep-id which is only supported in rootless mode as shown in the stderr

@zeyugao Sounds fair, thanks for explaining. Could we detect root by e.g. doing def is_root(): return os.geteuid() == 0 and then adjusting expected return code based on that? This would make integration test work in both rootful and rootless mode.

zeyugao · 2025-04-22T01:29:58Z

I have considered it as a solution, but this will make the CI on GitHub Actions unable to test the functionality correctly, making it less usefully. We have to test it locally.

zeyugao · 2025-04-24T02:05:58Z

I have changed the expected exit code accordingly

Signed-off-by: Elsa <[email protected]>

p12tic

Looks great, thank you!

p12tic · 2025-05-10T11:40:32Z

I rebased the PR and fixed merge conflict.

p12tic reviewed Apr 8, 2025

View reviewed changes