Add subpath support to volumes with type volume in --mount option
#1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fccagou
force-pushed
the
feat-process-subpath-in-volume-type
branch
3 times, most recently
from
e4f7ada to
740aa00
Compare
p12tic
approved these changes
Dec 8, 2025
Collaborator
p12tic
left a comment
p12tic
left a comment
There was a problem hiding this comment.
Looks good, but please check unit test failures.
fccagou
force-pushed
the
feat-process-subpath-in-volume-type
branch
7 times, most recently
from
20d75c3 to
e97a969
Compare
To allow subpath mount as describes in [Compose Specs](https://github.com/compose-spec/compose-spec/blob/main/05-services.md), Compose entries exemple: - type: volume source: webservices target: /srv/www/vhosts/server1 read_only: true volume: subpath: server1 - type: volume source: webservices target: /srv/www/vhosts/server2 read_only: true volume: subpath: server2 - type: volume source: webservices target: /srv/www/vhosts/server2/uploads read_only: false volume: subpath: server2/uploads Runs podman with options --mount type=volume,source=webservices,target=/srv/www/vhosts/server1,ro --mount type=volume,source=webservices,target=/srv/www/vhosts/server2,ro,subpath=server2 --mount type=volume,source=webservices,target=/srv/www/vhosts/server2/uploads,subpath=server2/uploads Signed-off-by: fccagou <[email protected]>
Contributor
Author
|
The test added is finally removed because get_mount_args calls assert_volume which fails running |
Collaborator
|
Tests can still be added for |
fccagou
force-pushed
the
feat-process-subpath-in-volume-type
branch
from
b302ecb to
0dd6e40
Compare
Contributor
Author
|
@p12tic, I just add the unittests and modify podman_compose.py to get it working. |
Contributor
Author
|
Hum, my commits messages have typo ... I change them ... |
fccagou
force-pushed
the
feat-process-subpath-in-volume-type
branch
from
0dd6e40 to
9b9c14f
Compare
podman_compose.py needs to be modified to allow the tests to run.
In the assert_volume function, an exception was raised because
compose.podman.output returns None, and the code then tries to call
decode("utf-8") on it.
This change removes the unnecessary call to decode.
Signed-off-by: fccagou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow subpath mount as describes in Compose Specs, in complement of #1336
Compose entries exemple:
Runs podman with options
Contributor Checklist:
If this PR adds a new feature that improves compatibility with docker-compose, please add a link
to the exact part of compose spec that the PR touches.
For any user-visible change please add a release note to newsfragments directory, e.g.
newsfragments/my_feature.feature. See newsfragments/README.md for more details.
All changes require additional unit tests.