Feat: implemented --wait* for podman-compose up and start #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mammo0 <[email protected]>
Signed-off-by: mammo0 <[email protected]>
Signed-off-by: mammo0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR addresses issues #710 and #1329.
The arguments
--waitand--wait-timeoutare added to podman-composeupandstartcommands. After starting the containers it waits until all services in the compose-file are eitherrunningorhealthy(if they have aHEALTCHCHECK).A note on the test cases: Currently they are skipped by GitHub actions. This comes from the used Docker image, which is currently the Debian
bookwormversion:podman-compose/.github/workflows/test.yml
Line 17 in ef9785a
And bookworm uses Podman version 4.3.1 (https://packages.debian.org/bookworm/podman). This version does not support checking for running or healthy state in
podman wait.