Print full dockerfile path instead of context on error#796
Closed
siteshwar wants to merge 1 commit intocontainers:mainfrom
Closed
Print full dockerfile path instead of context on error#796siteshwar wants to merge 1 commit intocontainers:mainfrom
siteshwar wants to merge 1 commit intocontainers:mainfrom
Conversation
... if the dockerfile is not found. Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
siteshwar
force-pushed
the
better-error-message
branch
from
70d091a to
3c3829d
Compare
Contributor
Author
|
Current error message is confusing and does not provide the exact path where the dockerfile is being searched. This change should help in debugging such cases. |
p12tic
requested changes
Mar 8, 2024
Collaborator
p12tic
left a comment
p12tic
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Could you please add examples of previous error message and current error message to the commit message? Also, the first line of the commit message needs to be 72 characters or less, otherwise it's hard wrapped by tools and people see broken sentence.
Also, please rebase on top of latest main branch.
Collaborator
|
Addressed in #1222. |
Collaborator
|
Merged via #1222. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... if the dockerfile is not found.