Implement sparse keyword for containers.list() #540
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@inknos We could do something crazy like default to True for libpod and False when compatible is True. Is that too odd for developers? It doesn't break current libpod scripts and it will work as expected for docker scripts. The other option is to wait for podman 6 and announce it as a breaking change. |
Right, I am in for the oddness, as it's not odd at all. (I'll put it down for future-me, who will forget about it) Having
We can always do this if we get a push from the community to unify the behaviours. Then we only need to flip the default. |
inknos
force-pushed
the
list-sparse
branch
4 times, most recently
from
fe3553b to
9a322ed
Compare
Defaults to True for Libpod calls and False for Docker Compat calls This ensures: 1. Docker API compatibility 2. No breaking changes with Libpod It also providest 1. Possibility to inspect containers on demand for list calls 2. Safer behavior if container hangs 3. Fewer expensive calls to the API by default Fixes: containers#459 Fixes: containers#446 Signed-off-by: Nicola Sella <[email protected]>
@jwhonce I need your guidance here. I made this pr mirroring what the docker behaviour is but this is a change for us. what's your opinion? this is a slowdown, would you rather see
sparse=Trueby default to keep the behavior consistent with the current one?