Add LXD support#143
Closed
FabienGhd wants to merge 2 commits into
Closed
Conversation
vmojzis
force-pushed
the
add-lxd-support
branch
2 times, most recently
from
5229f0b to
e8d0b2c
Compare
Collaborator
|
Thank you for the contribution and sorry it took so long to review. I took the liberty to fix issues reported by "black", added "Sign offs" (please use "git commit -s" in the future) and removed write_policy_for_lxd_mounts since it was almost the same as write_policy_for_containerd_mounts. |
Add support for LXD containers, enabling the generation of SELinux policies for LXD-managed containers. Signed-off-by: FabienGhd <guihard.fa@gmail.com>
- Use write_policy_for_containerd_mounts instead of write_policy_for_lxd_mounts (which was identical) - Fix "readonly" mounts - Add LXD basic test - Fix formatting based on "black" Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
Collaborator
|
Merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds support for LXD containers, enabling the generation of SELinux policies for LXD-managed containers.
I'm still quite new to all this, so any feedback would be greatly appreciated in any case.
Thank you! :)