Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser bundle: transpile dependencies and match ecma version #2175

Conversation

axe312ger
Copy link
Collaborator

@axe312ger axe312ger commented Mar 1, 2024

  1. latest axios is released in ECMA 2018 or later
  2. we support node v18, which is ECMA 2017+ -> we have to transpile down to ECMA 2017 (See: https://compat-table.github.io/compat-table/es2016plus/ - RegExp_Unicode_Property_Escapes)
  3. will potentially fix Contentful throws error on iPhone 6 iOS 12.5.7 when using Next.js Pages router #2131
  4. changes the dev tool to source maps, because the variant before wrapped all dependencies in eval - which resulted in our ecmascript compatability check NOT catching the ECMA version mismatch in the latest axios update

@axe312ger axe312ger requested a review from a team as a code owner March 1, 2024 13:54
@axe312ger axe312ger changed the title transpile dependencies and match ecma version browser bundle: transpile dependencies and match ecma version Mar 1, 2024
Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, great catch!

this is a big qol improvement

@mgoudy91 mgoudy91 merged commit 3e3aa24 into refactor/normalize-package-manager-usage Mar 1, 2024
1 check passed
@mgoudy91 mgoudy91 deleted the fix/transpile-dependencies-and-match-ecma-version branch March 1, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants