Skip to content

Fix: Properly truncate terminal output including stderr lines #7933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Properly truncate terminal output including stderr lines #7933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bad7573
Fix: Properly truncate terminal output including stderr lines
sestinj Sep 23, 2025
cfe4295
Merge branch 'main' into continue-1758668383923
sestinj Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 52 additions & 21 deletions extensions/cli/src/ui/ToolResultSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,42 +72,73 @@

// Handle terminal command output specially
if (toolName === "Bash") {
const isStderr = content.startsWith("Stderr:");
const actualOutput = isStderr ? content.slice(7).trim() : content;
const outputLines = actualOutput.split("\n");

if (outputLines.length <= MAX_BASH_OUTPUT_LINES) {
// Show actual output for MAX_BASH_OUTPUT_LINES lines or fewer
return (
<Box flexDirection="column">
<Box>
<Text color="dim">⎿ </Text>
<Text color="dim"> Terminal output:</Text>
// Parse the combined stdout + stderr output
// Format is either:
// - just stdout
// - stdout + "\nStderr: " + stderr
const allLines = content.split("\n");
const totalLines = allLines.length;

if (totalLines <= MAX_BASH_OUTPUT_LINES) {
// Show full output for MAX_BASH_OUTPUT_LINES lines or fewer
// Parse out stdout and stderr sections for proper coloring
const stderrIndex = content.indexOf("\nStderr: ");
if (stderrIndex !== -1) {

Check failure on line 86 in extensions/cli/src/ui/ToolResultSummary.tsx

View workflow job for this annotation

GitHub Actions / lint 

Unexpected negated condition
const stdout = content.slice(0, stderrIndex);
const stderr = content.slice(stderrIndex + 9); // Skip "\nStderr: "
return (
<Box flexDirection="column">
<Box>
<Text color="dim">⎿ </Text>
<Text color="dim"> Terminal output:</Text>
</Box>
<Box paddingLeft={2} flexDirection="column">
{stdout && (
<Text color="white">
{stdout.trimEnd()}
</Text>
)}
{stderr && (
<Text color="red">
Stderr: {stderr.trimEnd()}
</Text>
)}
</Box>
</Box>
<Box paddingLeft={2}>
<Text color={isStderr ? "red" : "white"}>
{actualOutput.trimEnd()}
</Text>
);
} else {
// Only stdout
return (
<Box flexDirection="column">
<Box>
<Text color="dim">⎿ </Text>
<Text color="dim"> Terminal output:</Text>
</Box>
<Box paddingLeft={2}>
<Text color="white">
{content.trimEnd()}
</Text>
</Box>
</Box>
</Box>
);
);
}
} else {
// Show first MAX_BASH_OUTPUT_LINES lines with ellipsis for more lines
const firstLines = outputLines.slice(0, MAX_BASH_OUTPUT_LINES).join("\n");
// Show first MAX_BASH_OUTPUT_LINES lines with truncation indicator
const firstLines = allLines.slice(0, MAX_BASH_OUTPUT_LINES).join("\n");
return (
<Box flexDirection="column">
<Box>
<Text color="dim">⎿ </Text>
<Text color="dim"> Terminal output:</Text>
</Box>
<Box paddingLeft={2}>
<Text color={isStderr ? "red" : "white"}>
<Text color="white">
{firstLines.trimEnd()}
</Text>
</Box>
<Box paddingLeft={2}>
<Text color="dim">
... +{outputLines.length - MAX_BASH_OUTPUT_LINES} lines
... +{totalLines - MAX_BASH_OUTPUT_LINES} lines
</Text>
</Box>
</Box>
Expand Down
Loading