WIP: Fix PowerShell command syntax issues in run_terminal_command tool #7973
+39
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add platform-specific command syntax guidance - Provide PowerShell-specific examples and instructions - Distinguish between && (bash) vs ; (PowerShell) for command chaining - Include proper directory creation syntax for PowerShell - Update parameter descriptions to be platform-aware - Add comprehensive PowerShell syntax warnings for AI Resolves issues where AI generated bash-style commands that failed in PowerShell environment, causing directory navigation and command execution problems.
PierrunoYT
requested review from
Patrick-Erichsen
and removed request for
a team
dosubot
bot
added
the
size:M
|
Nice! Curious if you have run this prompt for powershell as a rule and it's working as expected for you? |
|
Hello I could not test it yet. It should rather be marked as WIP. So people |
PierrunoYT
changed the title
…tool - Fix inconsistent indentation in parameters and evaluateToolCallPolicy - Clarify that PowerShell redirection operators (> >> < |) do work - Add native PowerShell cmdlet examples (Get-ChildItem, New-Item, etc.) - Correct path navigation guidance to include ./ support - Add PowerShell-specific example with Get-ChildItem -Recurse - Distinguish between PowerShell aliases vs native cmdlets 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Can someone take it over? |
|
@PierrunoYT can you share steps you've taken to validate that this is working correctly? Also if this is ready for review please mark it as such |
|
Hello I could not test it or verify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes PowerShell command syntax issues in the
runTerminalCommandtool that were causing AI-generated commands to fail in Windows PowerShell environments.Problem
&&instead of;)Solution
getPlatformCommandGuidance()function with comprehensive PowerShell syntax guidance;) vs bash (&&) command chainingmkdir,ls) and native cmdlets (New-Item,Get-ChildItem)./usageChanges Made
;) instead of&&for PowerShellmkdir dir1, dir2andNew-Item -ItemType Directory./paths work in PowerShellGet-ChildItem -Recurse *.jsTesting
Resolves command execution failures in PowerShell environments where bash-style syntax was being generated by AI agents.
🤖 Generated with Claude Code