Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow password retry on priv-key auth and try with empty password first automatically #1435

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

christianparpart
Copy link
Member

closes #1425.

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Jan 28, 2024
@christianparpart christianparpart force-pushed the feature/ssh-client-empty-password-auth branch from f715482 to 106bc5e Compare January 29, 2024 19:38
…word first automatically

Signed-off-by: Christian Parpart <[email protected]>
@christianparpart christianparpart force-pushed the feature/ssh-client-empty-password-auth branch from 106bc5e to 92c1520 Compare January 29, 2024 19:43
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a such way users will have only two oportunities to type correct password, while 3 is desired number

Yaraslaut
Yaraslaut previously approved these changes Jan 29, 2024
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, i am tired and do not see properly :(
LGTM

@Yaraslaut Yaraslaut enabled auto-merge January 29, 2024 21:41
@Yaraslaut Yaraslaut merged commit 864e725 into master Jan 30, 2024
57 checks passed
@Yaraslaut Yaraslaut deleted the feature/ssh-client-empty-password-auth branch January 30, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH should not ask for password if the key is not protected with one.
2 participants