Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set history lines default to 1000 rather than 0. #1438

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Set history lines default to 1000 rather than 0. #1438

merged 1 commit into from
Jan 29, 2024
+12 −9

Conversation

christianparpart
Copy link
Member

Closes #1424.

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Jan 29, 2024
Yaraslaut
Yaraslaut approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I suppose that initial bug was in bad inheritance of history limit value

@Yaraslaut Yaraslaut merged commit 9c224d8 into master Jan 29, 2024
57 checks passed
@Yaraslaut Yaraslaut deleted the fix/history-line-count-default branch January 29, 2024 21:18
@christianparpart
Copy link
Member Author

Exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yaraslaut Yaraslaut Yaraslaut approved these changes

Assignees
No one assigned
Labels
frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mouse scrolling is not working on not-main profile.
2 participants
@christianparpart @Yaraslaut