LLVM Backend #23
Draft
LLVM Backend #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/shell/llvm_executor.cpp
Outdated
| } | ||
| catch (std::exception const& e) | ||
| { | ||
| std::cout << "Exception caught: " << e.what(); |
There was a problem hiding this comment.
later on, we should bubble back errors in a way that does not require cout to work (imagine unit tests) :)
src/shell/llvm_executor.cpp
Outdated
Comment on lines
279
to
283
| void init() | ||
| { | ||
| InitializeNativeTarget(); | ||
| InitializeNativeTargetAsmPrinter(); | ||
| } |
There was a problem hiding this comment.
in LLVM, is there a counter-part to these init functions? If so, we'd need to also be able to call them. That would then probably look like we're about to do that either via a class (e.g. LLVMBackend or LLVMRunner ....) whose destructor would ensure that, such that the caller doesn't need to care nor even know about its need of such calls.
There was a problem hiding this comment.
this is llvm functions, this is definetely will be inside LLVMBackend class constructor
Yaraslaut
force-pushed
the
improvement/llvm_backend
branch
from
811da4d to
d5c577e
Compare
Yaraslaut
force-pushed
the
improvement/llvm_backend
branch
from
d5c577e to
fb11928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.