Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some benchmarks with unicode characters #17

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Add some benchmarks with unicode characters #17

merged 1 commit into from
Apr 1, 2024

Conversation

Yaraslaut
Copy link
Member

@Yaraslaut Yaraslaut commented Mar 19, 2024 •
edited
Loading

  • single codepoint grapheme clusters (aka. US-ASCII) should always be the fastest.
  • Diacritic
  • Diacritic for two codepoints
  • U+FE0F (VS16) for narrow-width GCs may affect perf due to width change (Diacritic)
  • invalid UTF-8 sequences might severily impact performance for 2 reasons (parsing as well as rendering that can impact parsing, depending on how a TE is implementing it)

@Yaraslaut Yaraslaut force-pushed the improvement/unicode_bench branch 10 times, most recently from fb7a8a2 to 8a9c9e6 Compare March 25, 2024 15:48
@github-actions github-actions bot added the CI label Mar 25, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/unicode_bench branch from 8a9c9e6 to 4d37f9b Compare March 25, 2024 15:52
@Yaraslaut Yaraslaut marked this pull request as ready for review March 25, 2024 16:00
christianparpart
christianparpart approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments

scripts/Xvfb-bench-run.sh Outdated Show resolved Hide resolved
tb/main.cpp Show resolved Hide resolved
@Yaraslaut Yaraslaut force-pushed the improvement/unicode_bench branch from 4d37f9b to 9e32854 Compare April 1, 2024 06:04
@christianparpart christianparpart merged commit 679b3cc into master Apr 1, 2024
3 checks passed
@christianparpart christianparpart deleted the improvement/unicode_bench branch April 1, 2024 08:50
@christianparpart
Copy link
Member

Thank you:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart Awaiting requested review from christianparpart

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaraslaut @christianparpart