Fix/complex template improvements#22
Open
stepankonecny96 wants to merge 3 commits intomainfrom
Open
Conversation
…late fixes - keda-scaledobject.yaml: wrap global.keda in parentheses so awsRegion lookup is nil-safe when global.keda is unset (otherwise template fails with nil pointer dereference instead of the intended fail message). - keda-triggerauthentication.yaml: replace `default true X` with `ne X false`. Go template's `default` treats literal false as empty and falls back to true, so triggerAuthEnabled: false had no effect. - serviceaccount.yaml: drop trailing `-}}` that was stripping the `---` document separator; remove redundant `and` with single argument in the global SA guard. - values.schema.json: register triggerAuthEnabled (boolean, default true) on kedaTriggerAwsSqsQueue (previously rejected as 'Additional property not allowed'); consolidate strategyType into definitions/strategyType referenced via \$ref from both global and per-component schemas, matching the existing rollingUpdate pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Chart.yaml: bump 1.8.3 -> 1.8.4 - README.md: regenerate via helm-docs (version badge 1.6.0 -> 1.8.4, trailing blank line fix) - README.md.gotmpl: move Persistent Volume Claims documentation into the helm-docs template so it survives future README regenerations. The previous prose section lived only in README.md and would be wiped on the next docs run. - testing-values/values-recreate.yaml: exercise strategyType: Recreate alongside default RollingUpdate across http, consumer. - testing-values/values-host-network.yaml: exercise hostNetwork + dnsPolicy across http, consumer, cronjob. - testing-values/values-node-name.yaml: exercise nodeName across http, consumer, cronjob, pre-job. - ci.yaml: wire all three new values files into both the lint and template-test jobs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…unts Same class of bug as the recently-fixed triggerAuthEnabled. The `default true .readOnly` guard treats a literal `false` as empty and falls back to `true`, so users who explicitly set `readOnly: false` on a configMap or secret volume mount silently got `readOnly: true`. Replace with `ne .readOnly false` which: - returns true when .readOnly is true (correct) - returns false when .readOnly is false (now correct, was wrong) - returns true when .readOnly is unset (preserves prior default) emptyDirs/others on lines 73/80 use `default false .readOnly` which is symmetric and correct by accident across all three input cases, so left as-is. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.