Introduce integration tests using real MySQL and PostgreSQL #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only had unit tests that used a mocked database adapter to test Arproxy. This approach sometimes led to scenarios where existing test cases would pass, but the actual functionality would fail when using a real database adapter.
Additionally, as seen in PR #28, when ActiveRecord is upgraded and its Connection specifications change, it becomes difficult to detect issues using only mocked unit tests.
To address these concerns, I have implemented integration tests that use Docker to test Arproxy with actual databases and adapters. As an initial step, I've implemented simple use cases for both MySQL and PostgreSQL.