Contributing Guide: minor changes #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 16, 2024 17:58
As far as I can see simply running `npm install` does the same (or even more) than installing the dependencies manually. You might know more than me, but this is what 4 years in NodeJS development told me :)
This is purely my personal opinion and meant as a suggestion rather than a fix! I would want the "Optional" in front so when I just want to edit one line in the docs, I know right away that I can skip it. Again: Personal opinion. Feel free to drop.
Again, purely personal opinion. I think first making the environment run before editing is the more natural way. For example, it reassures the contributor that everything works BEFORE the editing. If you like the other order more, feel free to drop this commit!
|
Thank you for the PR, it looks fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are ordered from severe to absolutely personal opinion. Please review them and feel free to drop the commits you don't like.