vine: don't print Submitted recovery task xxx to terminal
#4264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthain
reviewed
Nov 4, 2025
Member
dthain
left a comment
dthain
left a comment
There was a problem hiding this comment.
I'm thinking that we shouldn't introduce a new API entry point for every little statistic that we would like to return. How about modifying vine_stats instead?
In the past, I would be every loath to break ABI by changing the structure size, but I think everyone is coming through Python now, and it's easier to ensure a match between Python and C.
Member
Author
|
That is a good point! |
added 3 commits
November 5, 2025 12:27
btovar
approved these changes
Jan 5, 2026
Member
|
ready to merge? |
btovar
approved these changes
Jan 5, 2026
added 2 commits
January 5, 2026 12:57
Member
Author
|
RTM |
btovar
approved these changes
Jan 5, 2026
btovar
added a commit
that referenced
this pull request
Jan 6, 2026
* vine: don't print Submitted recovery xxx on terminal * trigger rebuild * use stats * restore * no factory display * merge * remove printf * lint --------- Co-authored-by: Jin Zhou <[email protected]> Co-authored-by: Benjamin Tovar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For now, whenever a recovery task is submitted, a message is printed to the user's terminal, which can be distracting.
Users don't need to know about individual recovery tasks or their operations, instead, they only care about the overall progress. If we do want to inform them, only the total number of recovery tasks is relavant
Therefore, we should stop printing
Submitted recovery task xxxto their terminal. Instead, the manager should track the number of recovery tasks submitted, and expose an API for the upper-level graph executor to decide whether or not to display that information.Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.