Skip to content

Conversation

@p1nox
Copy link

@p1nox p1nox commented Feb 9, 2013

p1nox added 2 commits February 9, 2013 11:10
- Upgrading Rails version for security matters after reading the heroku blog post "Rails Security Vulnerability" (https://blog.heroku.com/archives/2013/1/11/rails_security_vulnerability/)
- Upgrading Ruby version to 1.9.3 and beautifying of gemfile for performance matters according to the article "Speeding Up Heroku Boot Time for Rails app" (http://webcache.googleusercontent.com/search?q=cache:5XICWnTYQiMJ:devign.me/speeding-up-heroku-boot-time-for-rails-app-beating-the-error-r10-boot-timeout/+&cd=7&hl=en&ct=clnk)
@betelgeuse
Copy link

The first commit is a duplicate for #81.

@p1nox
Copy link
Author

p1nox commented Feb 10, 2013

I linked this pull request to issue 81 beacause it was a upgrading feature, and it would be nice to upgrade to Ruby 1.9.3 and swaping jquery-rails to assets group.

What can I do to fix it? Create another pull request just with changes different to the rails version on the gemfile?

@betelgeuse
Copy link

@p1nox #81 is also a pull request. The bigger problem here seems to be that the maintainers are not responsive.

@p1nox
Copy link
Author

p1nox commented Feb 11, 2013

Ok, I think that the solution here is to wait for maintainers decision, and sorry for the duplicated commit.

@p1nox p1nox closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants