Skip to content

Do not trigger Git Commit Linter and Dependency Review when draft PR is ready for review#1044

Merged
jtrobles-cdd merged 1 commit into
developfrom
revert-workaround-for-gha-workflow-for-release-and-deploy
Jun 17, 2026
Merged

Do not trigger Git Commit Linter and Dependency Review when draft PR is ready for review#1044
jtrobles-cdd merged 1 commit into
developfrom
revert-workaround-for-gha-workflow-for-release-and-deploy

Conversation

@jtrobles-cdd

Copy link
Copy Markdown
Member

Reverted commits b7ea3ab and 10f866f because that workaround is no longer needed after the change described in the GitHub Changelog on 2026-06-11:

From GitHub Changelog → Bot-created pull requests can run workflows if approved:

Pull requests created by the github-actions[bot] are now able to run
your CI/CD workflows with user approval. Requiring approval is a security
measure to ensure generated code does not automatically run workflows
which may have access to sensitive information. […]

Previously, pull requests generated by github-actions[bot] were not
able to run CI/CD workflows, allowing pull requests to be accidentally
merged without having gone through CI. This change allows all pull requests,
even bot-generated changes, to run configured CI/CD workflows if approved
by a user with write access to the repository.

Reverted commits b7ea3ab and
10f866f because that workaround is no
longer needed after the change described in the GitHub Changelog on 2026-06-11:

From [GitHub Changelog → Bot-created pull requests can run workflows if approved](https://github.blog/changelog/2026-06-11-bot-created-pull-requests-can-run-workflows-if-approved/):

> Pull requests created by the `github-actions[bot]` are now able to run
> your CI/CD workflows with user approval. Requiring approval is a security
> measure to ensure generated code does not automatically run workflows
> which may have access to sensitive information. […]
>
> Previously, pull requests generated by `github-actions[bot]` were not
> able to run CI/CD workflows, allowing pull requests to be accidentally
> merged without having gone through CI. This change allows all pull requests,
> even bot-generated changes, to run configured CI/CD workflows if approved
> by a user with write access to the repository.
@jtrobles-cdd jtrobles-cdd self-assigned this Jun 17, 2026
@jtrobles-cdd jtrobles-cdd requested a review from a team as a code owner June 17, 2026 15:38
@jtrobles-cdd jtrobles-cdd added the task Task or chore label Jun 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

@jtrobles-cdd jtrobles-cdd merged commit 7981092 into develop Jun 17, 2026
39 of 44 checks passed
@jtrobles-cdd jtrobles-cdd deleted the revert-workaround-for-gha-workflow-for-release-and-deploy branch June 17, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task Task or chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant