-
Notifications
You must be signed in to change notification settings - Fork 12
rcv: Add RvTipoVenta enum to represent "Tipo de Venta" in RCV #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new enum RvTipoVenta
to represent "Tipo de Venta" (Sales Type) values in the RCV domain, extending the constants module with two sales type options.
- Adds
RvTipoVenta
enum with two members:DEL_GIRO
andNO_CORRESPONDE_INCLUIR
- Includes comprehensive test coverage for the new enum
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/cl_sii/rcv/constants.py | Adds the new RvTipoVenta enum with two sales type constants |
src/tests/test_rcv_constants.py | Adds test class with coverage for enum members and value types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #852 +/- ##
===========================================
+ Coverage 87.84% 87.87% +0.02%
===========================================
Files 38 38
Lines 3193 3199 +6
Branches 323 323
===========================================
+ Hits 2805 2811 +6
Misses 249 249
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NO_CORRESPONDE_INCLUIR = "NO_CORRESPONDE_INCLUIR" | ||
"""No corresponde incluir""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NO_CORRESPONDE_INCLUIR = "NO_CORRESPONDE_INCLUIR" | |
"""No corresponde incluir""" | |
BIENES_RAICES = "BIENES_RAICES" | |
"""Bienes Raíces""" | |
ACTIVO_FIJO = "ACTIVO_FIJO" | |
"""Activo Fijo""" |
Ref: https://app.shortcut.com/cordada/story/16108/