Skip to content

rcv: Add RvTipoVenta enum to represent "Tipo de Venta" in RCV #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

svillegas-cdd
Copy link
Contributor

@svillegas-cdd svillegas-cdd self-assigned this Aug 20, 2025
@svillegas-cdd svillegas-cdd requested a review from a team as a code owner August 20, 2025 22:05
@svillegas-cdd svillegas-cdd added enhancement New feature or request component: rcv labels Aug 20, 2025
@svillegas-cdd svillegas-cdd requested a review from Copilot August 20, 2025 22:05
Copy link

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new enum RvTipoVenta to represent "Tipo de Venta" (Sales Type) values in the RCV domain, extending the constants module with two sales type options.

  • Adds RvTipoVenta enum with two members: DEL_GIRO and NO_CORRESPONDE_INCLUIR
  • Includes comprehensive test coverage for the new enum

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/cl_sii/rcv/constants.py Adds the new RvTipoVenta enum with two sales type constants
src/tests/test_rcv_constants.py Adds test class with coverage for enum members and value types

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.87%. Comparing base (029763a) to head (6962b32).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #852      +/-   ##
===========================================
+ Coverage    87.84%   87.87%   +0.02%     
===========================================
  Files           38       38              
  Lines         3193     3199       +6     
  Branches       323      323              
===========================================
+ Hits          2805     2811       +6     
  Misses         249      249              
  Partials       139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +332 to +333
NO_CORRESPONDE_INCLUIR = "NO_CORRESPONDE_INCLUIR"
"""No corresponde incluir"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NO_CORRESPONDE_INCLUIR = "NO_CORRESPONDE_INCLUIR"
"""No corresponde incluir"""
BIENES_RAICES = "BIENES_RAICES"
"""Bienes Raíces"""
ACTIVO_FIJO = "ACTIVO_FIJO"
"""Activo Fijo"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants