-
Notifications
You must be signed in to change notification settings - Fork 12
cte: Add parser for "Datos del Contribuyente" #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
cte: Add parser for "Datos del Contribuyente" #890
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The PR implements a parser for the "Datos del Contribuyente" (Taxpayer Data) section from CTE HTML content. It adds functionality to extract taxpayer information including start dates, activities, tax categories, and document filings.
- Implemented
parse_taxpayer_data
function to parse taxpayer data from CTE HTML - Added
TaxpayerData
andLastFiledDocument
data models with proper field definitions - Created comprehensive tests to validate parser functionality with sample HTML input
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/tests/test_data/sii-cte/cte_empty_f29.html | Sample HTML test data containing CTE structure with taxpayer information |
src/tests/test_cte_parsers.py | Test cases for the new taxpayer data parser functionality |
src/cl_sii/cte/parsers.py | Implementation of parse_taxpayer_data parser function |
src/cl_sii/cte/data_models.py | New data models TaxpayerData and LastFiledDocument |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #890 +/- ##
===========================================
- Coverage 88.97% 88.84% -0.14%
===========================================
Files 40 40
Lines 3565 3631 +66
Branches 355 366 +11
===========================================
+ Hits 3172 3226 +54
- Misses 240 244 +4
- Partials 153 161 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5cc7d54
to
a82e219
Compare
- Implemented `parse_taxpayer_data` to parse taxpayer data from CTE HTML. - Added `TaxpayerData` and `LastFiledDocument` data models. - Created tests to validate parser functionality with sample HTML input. Ref: https://app.shortcut.com/cordada/story/16534/
a82e219
to
892f19c
Compare
|
parse_taxpayer_data
to parse taxpayer data from CTE HTML.TaxpayerData
andLastFiledDocument
data models.Ref: https://app.shortcut.com/cordada/story/16534/