-
Notifications
You must be signed in to change notification settings - Fork 12
rcv: Replace float
with Decimal
for tasa_otro_impuesto
#909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rcv: Replace float
with Decimal
for tasa_otro_impuesto
#909
Conversation
tasa_otro_impuesto
tasa_otro_impuesto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds validation for the tasa_otro_impuesto
field to round values to 6 decimal places and updates corresponding test data.
- Implemented a field validator to round
tasa_otro_impuesto
to 6 decimal places when it exceeds this precision - Updated test data to use a value with more than 6 decimal places to test the validation
- Modified test expectations to reflect the rounded values
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
src/cl_sii/rcv/data_models.py | Added field validator to round tasa_otro_impuesto to 6 decimal places |
src/tests/test_rcv_parse_csv.py | Updated test expectations to use rounded values |
src/tests/test_data/sii-rcv/RCV-compra-reclamado.csv | Added test data with more than 6 decimal places |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
efb4453
to
f7198fb
Compare
f7198fb
to
2d235c1
Compare
tasa_otro_impuesto
float
with Decimal
for tasa_otro_impuesto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@jtrobles-cdd I haven't found a solution for the build errors, do you have an idea? |
I merged a pair of PRs so that the GitHub Actions cache gets updated. I don't know if that'll help, but try rebasing onto |
- Updated `tasa_otro_impuesto` data type to `Decimal` for improved precision. - Removed redundant validator for rounding `tasa_otro_impuesto`. - Adjusted parsers and tests for the new data type. Ref: https://app.shortcut.com/cordada/story/16788/
2d235c1
to
629383c
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #909 +/- ##
========================================
Coverage 89.39% 89.40%
========================================
Files 40 40
Lines 3726 3728 +2
Branches 378 378
========================================
+ Hits 3331 3333 +2
Misses 243 243
Partials 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tasa_otro_impuesto
data type toDecimal
for improved precision.tasa_otro_impuesto
.Ref: https://app.shortcut.com/cordada/story/16788