Skip to content

rcv: Update RV fields optional in schemas and data models #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svillegas-cdd wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

rcv: Update RV fields optional in schemas and data models #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/cl_sii/rcv/data_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,17 +344,17 @@ class RvDetalleEntry(RcvDetalleEntry):
Fecha Reclamo (must be timezone aware)
"""

monto_exento: int
monto_exento: Optional[int]
"""
Monto Exento
"""

monto_neto: int
monto_neto: Optional[int]
"""
Monto Neto
"""

monto_iva: int
monto_iva: Optional[int]
"""
Monto IVA
"""
Expand Down Expand Up @@ -389,22 +389,22 @@ class RvDetalleEntry(RcvDetalleEntry):
RUT Emisor Liquid. Factura
"""

neto_comision_liquidacion_factura: int
neto_comision_liquidacion_factura: Optional[int]
"""
Neto Comision Liquid. Factura
"""

exento_comision_liquidacion_factura: int
exento_comision_liquidacion_factura: Optional[int]
"""
Exento Comision Liquid. Factura
"""

iva_comision_liquidacion_factura: int
iva_comision_liquidacion_factura: Optional[int]
"""
IVA Comision Liquid. Factura
"""

iva_fuera_de_plazo: int
iva_fuera_de_plazo: Optional[int]
"""
IVA fuera de plazo
"""
Expand All @@ -429,7 +429,7 @@ class RvDetalleEntry(RcvDetalleEntry):
Nacionalidad Receptor Extranjero
"""

credito_empresa_constructora: int
credito_empresa_constructora: Optional[int]
"""
Credito empresa constructora
"""
Expand All @@ -439,27 +439,27 @@ class RvDetalleEntry(RcvDetalleEntry):
Impto. Zona Franca (Ley 18211)
"""

garantia_dep_envases: int
garantia_dep_envases: Optional[int]
"""
Garantia Dep. Envases
"""

indicador_venta_sin_costo: int
indicador_venta_sin_costo: Optional[int]
"""
Indicador Venta sin Costo
"""

indicador_servicio_periodico: int
indicador_servicio_periodico: Optional[int]
"""
Indicador Servicio Periodico
"""

monto_no_facturable: int
monto_no_facturable: Optional[int]
"""
Monto No facturable
"""

total_monto_periodo: int
total_monto_periodo: Optional[int]
"""
Total Monto Periodo
"""
Expand Down
39 changes: 26 additions & 13 deletions src/cl_sii/rcv/parse_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,15 +523,18 @@ class RcvVentaCsvRowSchema(_RcvCsvRowSchemaBase):
data_key='Fecha Reclamo',
)
monto_exento = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Monto Exento',
)
monto_neto = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Monto Neto',
)
monto_iva = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Monto IVA',
)
monto_total = marshmallow.fields.Integer(
Expand Down Expand Up @@ -569,19 +572,23 @@ class RcvVentaCsvRowSchema(_RcvCsvRowSchemaBase):
data_key='RUT Emisor Liquid. Factura',
)
neto_comision_liquidacion_factura = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Neto Comision Liquid. Factura',
)
exento_comision_liquidacion_factura = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Exento Comision Liquid. Factura',
)
iva_comision_liquidacion_factura = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='IVA Comision Liquid. Factura',
)
iva_fuera_de_plazo = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='IVA fuera de plazo',
)
tipo_documento_referencia = marshmallow.fields.Integer(
Expand All @@ -605,7 +612,8 @@ class RcvVentaCsvRowSchema(_RcvCsvRowSchemaBase):
data_key='Nacionalidad Receptor Extranjero',
)
credito_empresa_constructora = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Credito empresa constructora',
)
impuesto_zona_franca_ley_18211 = marshmallow.fields.Integer(
Expand All @@ -614,23 +622,28 @@ class RcvVentaCsvRowSchema(_RcvCsvRowSchemaBase):
data_key='Impto. Zona Franca (Ley 18211)',
)
garantia_dep_envases = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Garantia Dep. Envases',
)
indicador_venta_sin_costo = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Indicador Venta sin Costo',
)
indicador_servicio_periodico = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Indicador Servicio Periodico',
)
monto_no_facturable = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Monto No facturable',
)
total_monto_periodo = marshmallow.fields.Integer(
required=True,
required=False,
allow_none=True,
data_key='Total Monto Periodo',
)
venta_pasajes_transporte_nacional = marshmallow.fields.Integer(
Expand Down
1 change: 1 addition & 0 deletions src/tests/test_data/sii-rcv/RCV-venta-missing-required-fields.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Nro;Tipo Doc;Tipo Venta;Rut cliente;Razon Social;Folio;Fecha Docto;Fecha Recepcion;Fecha Acuse Recibo;Fecha Reclamo;Monto Exento;Monto Neto;Monto IVA;Monto total;IVA Retenido Total;IVA Retenido Parcial;IVA no retenido;IVA propio;IVA Terceros;RUT Emisor Liquid. Factura;Neto Comision Liquid. Factura;Exento Comision Liquid. Factura;IVA Comision Liquid. Factura;IVA fuera de plazo;Tipo Docto. Referencia;Folio Docto. Referencia;Num. Ident. Receptor Extranjero;Nacionalidad Receptor Extranjero;Credito empresa constructora;Impto. Zona Franca (Ley 18211);Garantia Dep. Envases;Indicador Venta sin Costo;Indicador Servicio Periodico;Monto No facturable;Total Monto Periodo;Venta Pasajes Transporte Nacional;Venta Pasajes Transporte Internacional;Numero Interno;Codigo Sucursal;NCE o NDE sobre Fact. de Compra;Codigo Otro Imp.;Valor Otro Imp.;Tasa Otro Imp.
1;"";Del Giro;12345678-5;Fake Company S.A. ;506;04/06/2019;"";;;0;1750181;332534;2082715;0;0;0;0;0;-;0;0;0;0;;;;;0;;0;2;0;0;0;;;;0;;;;;
23;33;Del Giro;12345678-5; Fake Company S.A.;508;28/06/2019;01/07/2019 13:49:42;;;0;2209597;419823;2629420;0;0;0;0;0;-;0;0;0;0;0;;;;0;;0;2;0;0;0;;;;0;;;;;
3;30;Del Giro;4954153-8;Faker Company;88;04/08/2017;13/09/2017 10:18:59;;;;15915315;3023910;18939225;;;;;;-;;;;;;;;;;;;;;;;;;;;;;;;
Loading