Conversation
✅ Deploy Preview for redi-love ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
abrar-amin
requested review from
clementroze and
jujulcrane
and removed request for
clementroze
jujulcrane
left a comment
jujulcrane
left a comment
There was a problem hiding this comment.
Looks great Abrar, thanks for fixing these bugs!
Were you able to test that the onboarding video still plays when the user is new? It probably does because I don't think your code could of messed that up but it's good to test it just incase if possible. (I'm saying this because I rebuilt the app and it didn't play but idk if me rebuilding the app counts as a new user or not?)
clementroze
left a comment
clementroze
left a comment
There was a problem hiding this comment.
thx abrar, just make sure to fix the 2 alerts and also some follow up comments :)
| const NUM_COLUMNS = 3; // 3 columns for a 2x3 grid (6 items total) | ||
| const GRID_GAP = 4; // Gap between items | ||
| const HORIZONTAL_PADDING = 32; // Account for parent container padding (16 on each side) | ||
| const HORIZONTAL_PADDING = 40; // Account for parent container padding (20 on each side) |
There was a problem hiding this comment.
hang on, this introduces a regression in the photoupload grid in Edit Profile
In the current production it's working correctly (and at different display/zoom sizes), but on ur branch, you can see it appears cut off:
| adjustsFontSizeToFit | ||
| minimumFontScale={0.8} |
| }, | ||
| buttonContainer: { | ||
| flexDirection: 'row', | ||
| flexWrap: 'wrap', |
There was a problem hiding this comment.
do you have a pic of the before/after of this?
i can't seem to test it on local rn (prob cuz match cards aren't shown yet?)
| {showOnboarding && ( | ||
| <OnboardingVideo | ||
| visible={showOnboarding} | ||
| onFinish={handleOnboardingFinish} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
thanks for this fix! While you're at it, do you also wanna try fixing the Log in page flashing briefly before you go to Home?
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-11-30.at.11.26.34.mp4
✅ Deploy Preview for redi-love ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
4 participants
Summary
Changes:
Profile screen: Added text wrapping for long display names and fixed container flex properties to prevent overflow
Button component: Added text scaling and a single-line constraint to handle long button text gracefully
Weekly match card: Added flexWrap to the button container to prevent layout issues
Onboarding video optimization: Only render the OnboardingVideo component when actually visible (the video player kept popping up briefly).
Index screen: Added persistent storage check to skip the onboarding video for returning users
Photo upload grid: Adjusted horizontal padding calculation to fix spacing
Test Plan
Simulator.Screen.Recording.-.iPhone.17.-.2025-11-27.at.18.55.47.mov
Note: This new introduces a new bug where the app flashes the log in page briefly.