Fix some routing issues by abrar-amin · Pull Request #112 · cornell-dti/redi

abrar-amin · 2026-03-08T02:35:44Z

Summary

Sign-out animation: home screen slides in from the left when navigating to login/home on sign-out (looks kinda cool now ngl)
Double sign-out bug: removed duplicate router.replace('/home') calls from profile.tsx (sign-out) and account-settings.tsx (delete account) (see the videos)
Blank white screen on email sign-in link: created app/auth-redirect.tsx with a loading spinner as the landing screen for email deep links
Deep link routing: updated redi-web /auth-redirect page to build redi:///auth-redirect?params instead of redi://?params so Expo Router routes to auth-redirect.tsx instead of index.tsx (index now has a spinner too)
Onboarding video check: moved from index.tsx to home.tsx
Sign-out destination: _layout.tsx now routes to /home instead of / on sign-out to avoid going through index.tsx (looks more seamless)

Simulator.Screen.Recording.-.iPhone.17.-.2026-03-07.at.21.24.59.mov

Simulator.Screen.Recording.-.iPhone.17.-.2026-03-07.at.21.23.51.mov

Simulator.Screen.Recording.-.iPhone.17.-.2026-03-07.at.21.20.07.mov

Simulator.Screen.Recording.-.iPhone.17.-.2026-03-07.at.21.19.37.mov

netlify · 2026-03-08T02:35:49Z

✅ Deploy Preview for redi-love ready!

Name	Link
🔨 Latest commit	`a578c21`
🔍 Latest deploy log	https://app.netlify.com/projects/redi-love/deploys/69ae1d884942f80008ee0004
😎 Deploy Preview	https://deploy-preview-112--redi-love.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

laylaliuuu

Great work on this refactor and bug fix, Abrar! Centralizing the routing logic into the root layout and adding the auth-redirect flow makes the app’s feel much more robust and professional.

The only major issue is I did run into a bug and it got stuck on the loading page, make sure to address that issue and some other minor issues. But awesome job!

laylaliuuu · 2026-03-08T22:02:52Z

frontend/app/(auth)/(tabs)/profile.tsx

Hi! Just a tiny clean-up note here, it looks like the CI is flagging "loading" from useProfile(). It would be great to remove it just to keep the file tidy and make sure no CI check warning

laylaliuuu · 2026-03-08T22:04:26Z

frontend/app/(auth)/(tabs)/profile.tsx

      await signOutUser();
      console.log('Sign out successful');
      setShowSignOutSheet(false);
-      router.replace('/home' as any);


Nice fix here to avoid route the user twice

laylaliuuu · 2026-03-08T22:15:11Z

frontend/app/(auth)/_layout.tsx


 export default function AuthLayout() {
+  useEffect(() => {
+    SplashScreen.hideAsync();


Just a super minor thing, since SplashScreen.hideAsync() returns a promise, it might be safer to just add a quick .catch() to the end of it, just to prevent any unhandled promise rejection, but I don't think it will actually cause any issue, totally up to you to change it or not

I think keeping it as is should be ok

yeah sounds good

laylaliuuu · 2026-03-08T22:43:14Z

frontend/app/(auth)/account-settings.tsx

              variant="secondary"
              title="Cannot change email address"
-              onPress={() => {}}
+              onPress={() => { }}


I was looking at this email address section where we have the empty onPress={() => {}}. Since we can't actually edit the email right now, it might be a bit confusing for users if it looks and feels like a clickable button but doesn't do anything when tapped.

Perhaps instead of a clickable row, we could just display their email as static text, maybe with a little gray subtitle underneath saying 'Email cannot be changed'? I think that might make the UI feel a bit more intuitive. If it's not too hard to swap out, I think that would be a good UX polish.

That's true; this is a remnant from when we were discussing not tying it NetIDs

I will defer to @clementroze on this

yeah let me know what clement say about this, we can add that to the next PR thing if needs to be fixed

i dont think it looks or feels like a clickable button because its disabeld (muted + gray) and there are no press states (bc of the disabled state)

see here -

i think we should still keep it bc its typical to be able to change your email in apps. Since we dont allow it because we have a special sign in with Cornell SSO case, we should still show which email they're signed in on for visibility.

i also think we should follow the pattern of rather still showing something, but making it disabled, rather than just hiding or removing it completely

lmk what yall think

laylaliuuu · 2026-03-08T22:48:35Z

frontend/app/(auth)/create-profile.tsx

      }

+      await refreshProfile();
+


Awesome catch adding await refreshProfile() here before routing! This is a great way to prevent any weird split-second loading glitches or stale data.

laylaliuuu · 2026-03-08T23:39:56Z

frontend/app/_layout.tsx

-        />
-      </Stack>
-      {showOnboarding && (
-        <OnboardingVideo


I noticed we moved the OnboardingVideo logic from index.tsx over to home.tsx

Just a quick thought: if a brand-new user joins via a deep link, they usually go straight from create-profile to the main app tabs, and might skip the home page entirely. Will they miss the onboarding video in that case? I'm not sure if we want all new users to see it regardless of how they join, but just wanted to check if this move was intentional

The onboarding video is more of a first time install thing; a user should not be able to get a sign-in link until they have launched the app.

laylaliuuu · 2026-03-08T23:43:21Z

frontend/app/auth-redirect.tsx

+// _layout.tsx handles the actual sign-in and routes away when done.
+export default function AuthRedirect() {
+  useEffect(() => {
+  }, []);


we have an empty useEffect hook here. Did you have plans to put some deep-link logic in here originally? If not, we can probably just delete those lines to keep the code clean since empty useEffect hook does nothing.

I was toying around with the splash screen stuff and removed the code in here lmfao but not the effect

laylaliuuu · 2026-03-08T23:52:28Z

frontend/app/home.tsx

  };

+  useEffect(() => {
+    SplashScreen.hideAsync();


Just like the other layout file, since SplashScreen.hideAsync() returns a promise, we might want to add a quick .catch() here just to keep the promise handling consistent across the app

laylaliuuu · 2026-03-08T23:55:21Z

frontend/app/home.tsx

-  const handleVideoFinish = () => {
+  const handleVideoFinish = async () => {
+    await markOnboardingVideoAsShown();
    setShowVideo(false);


Just a small thought on the handleVideoFinish timing. Right now we are await the save before we call setShowVideo(false). If the storage write is a bit slow, the user might see the video stay on the screen for a second after it ends.

We could probably move setShowVideo(false) to the top of the function so the video disappears instantly while the save happens in the background! But also i don't think it's a big issue, so totally up to you to change the order or not.

laylaliuuu · 2026-03-08T23:59:03Z

frontend/app/index.tsx

+import LoadingSpinner from './components/ui/LoadingSpinner';

 export default function Index() {
-  const [showVideo, setShowVideo] = useState(false);


again, is it intentional we moved the show video logic out of here to home.tsx, and will it change any behaviors of showing the video and everything

For some reason or another, the deep link takes a user to the index page, so I changed the index page to function as a loading screen.

abrar-amin · 2026-03-09T01:08:14Z

Simulator.Screen.Recording.-.iPhone.17.-.2026-03-08.at.21.07.02.mov

Here's the new behavior for using expired links

sonarqubecloud · 2026-03-09T01:10:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

laylaliuuu

Thank you for addressing all the comments so quickly!! I was testing the bug you fixed, it seems good!! the only one minor thing is let’s say if the user is logged in, and they clicked on the invalid link to open the link they are automitaclly logged out, which is kinda annoying (just in case if they ever click on the wrong link and accidentally clicked “open”) do you think we should change that

clementroze · 2026-03-09T14:54:20Z

yyay

abrar-amin added 4 commits March 7, 2026 13:42

Fix deleting profile issue

1415857

Update create-profile.tsx

a850e24

Added loading screen for login and rearranged page routing

a17c12d

Update account-settings.tsx

5a1bee5

abrar-amin added 4 commits March 7, 2026 21:38

Merge origin/main into fix-some-routing-issues, resolve conflicts

c2895fa

Restore loading spinner to index.tsx lost during merge resolution

90463f1

Update _layout.tsx

ee4b197

Update account-settings.tsx

8887534

abrar-amin requested review from clementroze, glopes2023, jacquelinecai, laylaliuuu and nadia-choop March 8, 2026 02:48

laylaliuuu requested changes Mar 9, 2026

View reviewed changes

Address comments in PR

a578c21

abrar-amin requested a review from laylaliuuu March 9, 2026 01:09

laylaliuuu approved these changes Mar 9, 2026

View reviewed changes

laylaliuuu merged commit dfec56f into main Mar 9, 2026
11 checks passed

laylaliuuu deleted the fix-some-routing-issues branch March 9, 2026 01:59

Conversation

abrar-amin commented Mar 8, 2026

Summary

Uh oh!

netlify bot commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for redi-love ready!

Uh oh!

laylaliuuu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abrar-amin commented Mar 9, 2026

Uh oh!

sonarqubecloud bot commented Mar 9, 2026

Quality Gate passed

Uh oh!

laylaliuuu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

clementroze commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Mar 8, 2026 •

edited

Loading

laylaliuuu left a comment •

edited

Loading