Skip to content

Conversation

@SungJin1212
Copy link
Member

This PR adds a parquet converter.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX], [DEPENDENCY]

Copy link
Collaborator

@kd7lxl kd7lxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. I'm excited to try out parquet storage.

@SungJin1212 SungJin1212 force-pushed the Add-parquet-converter branch from fbf87d3 to 9195829 Compare December 18, 2025 02:35
values.yaml Outdated
Comment on lines 1293 to 1297
# -- arbitrary snippet to inject in the http {} section of the nginx config
httpSnippet: ""
# -- arbitrary snippet to inject in the top section of the nginx config
mainSnippet: ""
# -- arbitrary snippet to inject in the server { } section of the nginx config
# -- arbitrary snippet to inject in the server {} section of the nginx config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see unrelated changes to these lines. Please no changes outside the scope of the PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the PR. Thanks

@SungJin1212 SungJin1212 requested a review from kd7lxl December 18, 2025 02:43
@SungJin1212
Copy link
Member Author

@kd7lxl
Thanks for the review. I fixed what you commented.

@kd7lxl
Copy link
Collaborator

kd7lxl commented Dec 18, 2025

Please address all the comments before re-requesting review.

@SungJin1212 SungJin1212 force-pushed the Add-parquet-converter branch from 1bfa34b to 2f00854 Compare December 18, 2025 03:05
Signed-off-by: SungJin1212 <[email protected]>
@SungJin1212 SungJin1212 force-pushed the Add-parquet-converter branch from 2f00854 to e8cf7f6 Compare December 19, 2025 01:32
@kd7lxl kd7lxl enabled auto-merge (squash) December 19, 2025 01:34
@kd7lxl kd7lxl merged commit 7d3c3a3 into cortexproject:master Dec 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants