-
Notifications
You must be signed in to change notification settings - Fork 168
Add parquet converter #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parquet converter #579
Conversation
kd7lxl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. I'm excited to try out parquet storage.
fbf87d3 to
9195829
Compare
values.yaml
Outdated
| # -- arbitrary snippet to inject in the http {} section of the nginx config | ||
| httpSnippet: "" | ||
| # -- arbitrary snippet to inject in the top section of the nginx config | ||
| mainSnippet: "" | ||
| # -- arbitrary snippet to inject in the server { } section of the nginx config | ||
| # -- arbitrary snippet to inject in the server {} section of the nginx config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see unrelated changes to these lines. Please no changes outside the scope of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the PR. Thanks
|
@kd7lxl |
|
Please address all the comments before re-requesting review. |
1bfa34b to
2f00854
Compare
Signed-off-by: SungJin1212 <[email protected]>
2f00854 to
e8cf7f6
Compare
This PR adds a parquet converter.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]