Skip to content

Conversation

bryansray
Copy link

But still maintain the OTel handlers.

Rationale

Remove the duplicate logging in CloudWatch, but still maintain the OpenTelemetry handlers.

TODO

  • Update CHANGELOG.md
  • Add any necessary tests

@bryansray bryansray requested review from smoke and Copilot September 18, 2025 16:36
@bryansray bryansray self-assigned this Sep 18, 2025
@bryansray bryansray added the bug Something isn't working label Sep 18, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the Corva logging system to prevent duplicate log entries in CloudWatch while preserving OpenTelemetry (OTel) log handling functionality. The solution disables log propagation on the CORVA_LOGGER and explicitly attaches OTel handlers when log sending is enabled.

Key changes:

  • Disables propagation on CORVA_LOGGER to prevent AWS Lambda root handler duplication
  • Adds utility functions to detect and gather OTel handlers from the root logger
  • Modifies LoggingContext to explicitly attach OTel handlers when appropriate

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

bryansray and others added 3 commits September 18, 2025 11:47
@smoke smoke requested a review from drymar September 19, 2025 07:28
@kossman kossman changed the base branch from master to version-one October 6, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants