Skip to content

feat: remove redis ping #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: remove redis ping #99

wants to merge 1 commit into from

Conversation

ville
Copy link

@ville ville commented Jun 19, 2025

Rationale

No need to make extra ping call

Changes

Removed ping call

TODO

  • Update CHANGELOG.md

@ville ville self-assigned this Jun 19, 2025
@suchov suchov requested a review from Copilot July 3, 2025 17:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes an unnecessary Redis ping call at adapter initialization and cleans up the related test.

  • Eliminated the initial self.client.ping() invocation from DeprecatedRedisAdapter.__init__
  • Removed the test_init_connect_exc test and its Redis import in tests/unit/state/test_redis_adapter.py
  • TODO reminder to update CHANGELOG.md

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/corva/cache_adapter.py Removed initial self.client.ping() call from the constructor
tests/unit/state/test_redis_adapter.py Deleted the test_init_connect_exc function and unused Redis import
Comments suppressed due to low confidence (1)

src/corva/cache_adapter.py:262

  • Update the docstring of DeprecatedRedisAdapter.__init__ to note that it no longer performs a connectivity check at instantiation.
    def __init__(

@suchov
Copy link
Member

suchov commented Jul 3, 2025

@ville what do you think about Copilot suggestions to remove intial self.client.ping() call form the constructor and delete test_init_connect_exc ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants