Skip to content

Change exception handling to track last exception #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlgrpe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change exception handling to track last exception #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3be721d
Change exception handling to track last exception
rlgrpe Dec 1, 2025
5f6c022
Fix exception variable name in IP retrieval
rlgrpe Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pythonlib/camoufox/ip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def public_ip(proxy: Optional[str] = None) -> str:
"https://ipecho.net/plain",
]

exception = None
last_exception = None
for url in URLS:
try:
with _suppress_insecure_warning():
Expand All @@ -116,5 +116,5 @@ def public_ip(proxy: Optional[str] = None) -> str:
validate_ip(ip)
return ip
except (requests.exceptions.ProxyError, requests.RequestException, InvalidIP) as exception:
pass
raise InvalidIP(f"Failed to get IP address: {exception}")
last_exception = exception
raise InvalidIP(f"Failed to get IP address: {last_exception}")