fix: correct deduplication of watch events #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is extracted from cosi-project#633 as a separate fix. The idea is that if we merge/deduplicate watch events, we should do this by immutable attributes of the resource: namespace, type, id. The previous implementation might split two events on e.g. finalizers being empty, so two events which report finalizers empty/finalizers non-empty might be delivered in the wrong order: first empty, next non-empty. It might not trigger a real bug due to the way controllers work, but still is not consistent and correct. Signed-off-by: Andrey Smirnov <[email protected]>
Unix4ever
approved these changes
Sep 1, 2025
yes, existing tests test this indirectly, it's the very core part of COSI |
utkuozdemir
approved these changes
Sep 1, 2025
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from #633 as a separate fix.
The idea is that if we merge/deduplicate watch events, we should do this by immutable attributes of the resource: namespace, type, id.
The previous implementation might split two events on e.g. finalizers being empty, so two events which report finalizers empty/finalizers non-empty might be delivered in the wrong order: first empty, next non-empty.
It might not trigger a real bug due to the way controllers work, but still is not consistent and correct.