Skip to content

Adding PsiChi plot in the source injector#360

Closed
GallegoSav wants to merge 6 commits intocositools:developfrom
GallegoSav:develop
Closed

Adding PsiChi plot in the source injector#360
GallegoSav wants to merge 6 commits intocositools:developfrom
GallegoSav:develop

Conversation

@GallegoSav
Copy link
Copy Markdown
Contributor

I added an option make_PsiChi_plot for getting the expected PsiChi map from the model.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2025

Codecov Report

❌ Patch coverage is 11.95652% with 324 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.45%. Comparing base (f22aa8a) to head (031d9e6).

Files with missing lines Patch % Lines
cosipy/data_io/UnBinnedData.py 11.64% 311 Missing ⚠️
cosipy/source_injector/source_injector.py 23.07% 10 Missing ⚠️
cosipy/data_io/ReadTraTest.py 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (11.95%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
cosipy/data_io/ReadTraTest.py 19.04% <0.00%> (-0.71%) ⬇️
cosipy/source_injector/source_injector.py 58.55% <23.07%> (-5.08%) ⬇️
cosipy/data_io/UnBinnedData.py 50.00% <11.64%> (-40.18%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ckarwin
Copy link
Copy Markdown
Contributor

ckarwin commented Jul 7, 2025

@GallegoSav What is the status of this PR? It seems to contain changes from the CO sequence, which should be part of PR #362. Also, I'm not sure why the entire unbinned data class has been recopied, and is actually duplicated in the file. Something is not right here. Also, the new code needs coverage. Please let me know the status.

@ckarwin ckarwin self-requested a review July 7, 2025 19:32
@ckarwin ckarwin self-assigned this Jul 7, 2025
@israelmcmc israelmcmc added pull-request-waiting-for-author The ball is on the author's side. Feature / Enhancement New functionality or improvement labels Sep 11, 2025
@GallegoSav GallegoSav closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature / Enhancement New functionality or improvement pull-request-waiting-for-author The ball is on the author's side.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants