Adding PsiChi plot in the source injector#360
Closed
GallegoSav wants to merge 6 commits intocositools:developfrom
Closed
Adding PsiChi plot in the source injector#360GallegoSav wants to merge 6 commits intocositools:developfrom
GallegoSav wants to merge 6 commits intocositools:developfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (11.95%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.
🚀 New features to boost your workflow:
|
Contributor
|
@GallegoSav What is the status of this PR? It seems to contain changes from the CO sequence, which should be part of PR #362. Also, I'm not sure why the entire unbinned data class has been recopied, and is actually duplicated in the file. Something is not right here. Also, the new code needs coverage. Please let me know the status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option
make_PsiChi_plotfor getting the expected PsiChi map from the model.