Skip to content

Earth occultation in ScAtt + Local image analysis#416

Merged
GallegoSav merged 12 commits intocositools:developfrom
hiyoneda:earth_occultation_scatt_local_allskyimaging
Oct 22, 2025
Merged

Earth occultation in ScAtt + Local image analysis#416
GallegoSav merged 12 commits intocositools:developfrom
hiyoneda:earth_occultation_scatt_local_allskyimaging

Conversation

@hiyoneda
Copy link
Copy Markdown
Contributor

@hiyoneda hiyoneda commented Oct 6, 2025

Following PR #381 , the Earth occultation is now considered in image analysis using local coordinate / scatt bin.

Basically, there are only two major changes:

  1. Now SpacecraftAttitudeExposureTable keeps the information about the Earth zenith and altitude of the satellite, which will be used for the Earth occultation calculation.
  2. In CoordsysConversionMatrix. spacecraft_attitude_binning_ccm, exposure time maps for all scatt bins are calculated. In this step, the Earth occultation is considered, and exposure time is set to zero if the Earth blocks a corresponding pixel.

Additionally, there are minor changes.

  • These methods are removed because they are not used anymore.
    • CoordsysConversionMatrix. time_binning_ccm
  • These methods are added
    • CoordsysConversionMatrix.calc_exposure_map: It can calculate an exposure map by convolving the exposure time map with the effective area for each scatt bin
    • SpacecraftAttitudeExposureTable.get_binned_data_scatt: It can generate a binned histogram from an event file. The generated histogram has 'ScAtt' in its axes. Initially, I planned to add it to the DataIO class, but considering that this approach (ScAtt + local) is not a default analysis, I decided to put it in SpacecraftAttitudeExposureTable to avoid confusion in the DataIO class.

@hiyoneda hiyoneda linked an issue Oct 6, 2025 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.23%. Comparing base (e9dca56) to head (ee1076a).
⚠️ Report is 81 commits behind head on develop.

Files with missing lines Patch % Lines
cosipy/image_deconvolution/exposure_table.py 96.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
.../image_deconvolution/coordsys_conversion_matrix.py 96.62% <100.00%> (-0.22%) ⬇️
cosipy/image_deconvolution/exposure_table.py 97.05% <96.00%> (-0.46%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@israelmcmc israelmcmc added the pull-request-needs-reviewer No reviewer assigned label Oct 6, 2025
Copy link
Copy Markdown
Contributor

@GallegoSav GallegoSav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with DC3 response and files and it worked well

@GallegoSav GallegoSav merged commit 41c4365 into cositools:develop Oct 22, 2025
4 checks passed
@hiyoneda hiyoneda deleted the earth_occultation_scatt_local_allskyimaging branch March 6, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Account for Earth's occultation in RL (scatt bins approach)

3 participants