Use fixed FITS reponse files to address issue #503#517
Merged
israelmcmc merged 2 commits intocositools:developfrom Mar 16, 2026
Merged
Use fixed FITS reponse files to address issue #503#517israelmcmc merged 2 commits intocositools:developfrom
israelmcmc merged 2 commits intocositools:developfrom
Conversation
added 2 commits
March 14, 2026 15:03
* update all checksums to reflect new FITS orientation files with correction for missing last line
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is associated with correcting the FITS orientation files in response to issue #503. The FITS DC3 orientation files used by the tutorials were missing their last line due to a bug in SpacecraftHistory's .ori reader. I have updated these FITS files on wasabi to include the missing last line and also uploaded new, fixed versions of the offending .ori files (with EN at the end) to the develop tree; I recommend that we replace the DC3 .ori files with the latter.
The patch itself updates the tutorial checksums for the new FITS files and also corrects a missing EN at the end of one of the test case .ori files.
This patch does nothing to try to fix the parsing of .ori files, as that is being addressed in a separate PR.
After this patch, both the test cases and notebooks all pass.