Skip to content

Use fixed FITS reponse files to address issue #503#517

Merged
israelmcmc merged 2 commits intocositools:developfrom
McKelvey-Engineering-CSE:fits-response-fix
Mar 16, 2026
Merged

Use fixed FITS reponse files to address issue #503#517
israelmcmc merged 2 commits intocositools:developfrom
McKelvey-Engineering-CSE:fits-response-fix

Conversation

@jdbuhler
Copy link
Contributor

@jdbuhler jdbuhler commented Mar 15, 2026

This patch is associated with correcting the FITS orientation files in response to issue #503. The FITS DC3 orientation files used by the tutorials were missing their last line due to a bug in SpacecraftHistory's .ori reader. I have updated these FITS files on wasabi to include the missing last line and also uploaded new, fixed versions of the offending .ori files (with EN at the end) to the develop tree; I recommend that we replace the DC3 .ori files with the latter.

The patch itself updates the tutorial checksums for the new FITS files and also corrects a missing EN at the end of one of the test case .ori files.

This patch does nothing to try to fix the parsing of .ori files, as that is being addressed in a separate PR.

After this patch, both the test cases and notebooks all pass.

Jeremy Buhler added 2 commits March 14, 2026 15:03
* update all checksums to reflect new FITS orientation files with
  correction for missing last line
@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.18%. Comparing base (4911568) to head (511e134).
⚠️ Report is 3 commits behind head on develop.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@israelmcmc
Copy link
Collaborator

Thanks @jdbuhler. I'm merging and we can continue the discussion about the parsing in #503 and #516

@israelmcmc israelmcmc merged commit 4b43a59 into cositools:develop Mar 16, 2026
7 checks passed
@jdbuhler jdbuhler deleted the fits-response-fix branch March 16, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants