Explicitly check for "EN" at end of .ori files#533
Open
jdbuhler wants to merge 2 commits intocositools:developfrom
Open
Explicitly check for "EN" at end of .ori files#533jdbuhler wants to merge 2 commits intocositools:developfrom
jdbuhler wants to merge 2 commits intocositools:developfrom
Conversation
an error otherwise * Fix for issue cositools#527 -- undefined var in get_exposure
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
interp and non-interp cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MEGAlib .ori files end with the tag "EN" on a line by itself. This tag is removed when the file is read in. Recently, we discovered that some .ori files in cosipy were missing that terminal EN; those files were fixed, but we still need to properly detect the missing EN.
This patch chooses to reject files without the terminal EN, rather than attempt to work around them, because trying to "do the right thing" would need to handle all sorts of cases. For example, there might be multiple lines of garbage at the end of the file.
This PR is intended to supersede #516.
Since I was editing this file anyway, I also included a one-line fix for issue #527 with a suitable test case.