Skip to content

Update InstallCosmo.cs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update InstallCosmo.cs #1

wants to merge 1 commit into from

Conversation

MoonHyper
Copy link

  • Init and top level properties are removed.
  • Unnecessary null checks are removed.
  • ExecuteCommand function simplified and made better.
  • Better readibility.

@MoonHyper
Update InstallCosmo.cs
209d958 
* Init and top level properties are removed.
* Unnecessary null checks are removed.
* ExecuteCommand function simplified and made better.
* Better readibility.
@R-unic
Copy link
Contributor

R-unic commented Jun 21, 2023 •
edited
Loading

i don't really understand some of these changes...
i prefer omitting braces where possible, looks like you added them back. i also dont understand why you're throwing an exception in the ExecuteCommand method???? exceptions crash the program with no error message. please try to fix and then i will merge, thank you for contributing :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoonHyper @R-unic